Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating tools/read_it_and_keep from version 0.2.2 to 0.3.0 #4523

Closed
wants to merge 1 commit into from
Closed

Updating tools/read_it_and_keep from version 0.2.2 to 0.3.0 #4523

wants to merge 1 commit into from

Conversation

planemo-autoupdate
Copy link
Contributor

Hello! This is an automated update of the following tool: tools/read_it_and_keep. I created this PR because I think the tool's main dependency is out of date, i.e. there is a newer version available through conda.

I have updated tools/read_it_and_keep from version 0.2.2 to 0.3.0.

Project home page: https://github.com/GenomePathogenAnalysisService/read-it-and-keep/releases

@wm75
Copy link
Contributor

wm75 commented Apr 25, 2022

v0.3.0 looks like a really trivial new release, which shouldn't change anything results-wise and doesn't offer anything new on the Galaxy side.
No idea why all tests are failing.

@mira-miracoli
Copy link
Contributor

v0.3.0 looks like a really trivial new release, which shouldn't change anything results-wise and doesn't offer anything new on the Galaxy side. No idea why all tests are failing.

I ran the tests and Conda said there would be no version 0.3.0 in bioconda, despite that, all tests "passed". However when I take a look at the conda site the Version is displayed there (bioconda/linux64).
When I run the tests using --docker, it seems to find nothing, either.

@bgruening
Copy link
Member

its now available and I restarted the tests

@wm75
Copy link
Contributor

wm75 commented Apr 26, 2022

Cool, that solved it! Thanks @mira-miracoli & @bgruening!

A more general question: What's the strategy with tool updates like this one?
There are no functional changes in this release that would impact the Galaxy wrapper in any way. Do we still want to have an accompanying wrapper release just to be up to date, or are too many insignificant version choices just a burden for admins and users?

@bgruening
Copy link
Member

A more general question: What's the strategy with tool updates like this one?
There are no functional changes in this release that would impact the Galaxy wrapper in any way. Do we still want to have an accompanying wrapper release just to be up to date, or are too many insignificant version choices just a burden for admins and users?

I think @simonbray had a plan :)

@simonbray simonbray mentioned this pull request May 9, 2022
Open
@simonbray
Copy link
Member

I think @simonbray had a plan :)

We can close this if you like.

@bgruening bgruening closed this May 9, 2022
@planemo-autoupdate planemo-autoupdate deleted the tools/read_it_and_keep branch May 10, 2022 09:11
@gxydevbot
Copy link
Collaborator

There are new updates, if you want to integrate them, close the PR and delete branch.

1 similar comment
@gxydevbot
Copy link
Collaborator

There are new updates, if you want to integrate them, close the PR and delete branch.

@gxydevbot
Copy link
Collaborator

There are new updates, they have been integrated to the PR, check the file diff.

1 similar comment
@gxydevbot
Copy link
Collaborator

There are new updates, they have been integrated to the PR, check the file diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@planemo-autoupdate @wm75 @mira-miracoli @bgruening @simonbray @gxydevbot